Cod 1293 resolve file path inside codspeed go#12
Merged
not-matthias merged 3 commits intocod-1284-dx-improvements-for-codspeed-gofrom Sep 2, 2025
Merged
Conversation
not-matthias
force-pushed
the
cod-1293-resolve-file-path-inside-codspeed-go
branch
from
4d0c5ed to
4df13ff
Compare
not-matthias
force-pushed
the
cod-1284-dx-improvements-for-codspeed-go
branch
from
daaef78 to
b0d22b7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR resolves file path issues in the CodSpeed Go runner by implementing a metadata-based approach to determine Git-relative paths for benchmark files. Instead of relying on environment variables, the system now creates a go-runner.metadata file containing profile folder and relative package path information, which is then used by the Go testing framework to generate proper URIs for benchmark results.
Key changes include:
- Implemented metadata file generation and parsing in Go testing framework
- Modified benchmark result structure to include both name and URI fields
- Refactored profile directory handling to be passed as parameters instead of environment variables
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| testing/testing/codspeed.go | New file implementing metadata parsing and Git-relative path resolution |
| testing/testing/benchmark.go | Updated to use metadata for file path resolution and generate proper benchmark URIs |
| go-runner/src/builder/templater.rs | Modified to generate go-runner.metadata file with profile and path information |
| go-runner/src/lib.rs | Refactored to pass profile directory as parameter instead of using environment variables |
| go-runner/src/results/raw_result.rs | Updated RawResult struct to include URI field and simplified benchmark creation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
not-matthias
force-pushed
the
cod-1284-dx-improvements-for-codspeed-go
branch
from
1b50d0a to
c0de34e
Compare
not-matthias
force-pushed
the
cod-1293-resolve-file-path-inside-codspeed-go
branch
from
4df13ff to
f9ddc46
Compare
not-matthias
force-pushed
the
cod-1284-dx-improvements-for-codspeed-go
branch
2 times, most recently
from
bc9c62e to
a209282
Compare
not-matthias
force-pushed
the
cod-1293-resolve-file-path-inside-codspeed-go
branch
from
f9ddc46 to
01ecfc8
Compare
CodSpeed Performance ReportMerging #12 will degrade performances by 33.94%Comparing Summary
Benchmarks breakdown
Footnotes |
not-matthias
force-pushed
the
cod-1284-dx-improvements-for-codspeed-go
branch
from
a209282 to
34f5844
Compare
not-matthias
force-pushed
the
cod-1293-resolve-file-path-inside-codspeed-go
branch
from
01ecfc8 to
0133765
Compare
art049
approved these changes
Sep 2, 2025
not-matthias
force-pushed
the
cod-1284-dx-improvements-for-codspeed-go
branch
from
34f5844 to
7cd6ee5
Compare
not-matthias
force-pushed
the
cod-1293-resolve-file-path-inside-codspeed-go
branch
from
0133765 to
b20d439
Compare
not-matthias
merged commit b20d439
into
cod-1284-dx-improvements-for-codspeed-go
9 checks passed
not-matthias
deleted the
cod-1293-resolve-file-path-inside-codspeed-go
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.